Update Cujo example to use bower_components

[stephenplusplus]

@briancavalier,

@sindresorhus pegged you as someone who can help with this task.

I recently went through the Cujo application and configured the bower.json file for all of the components-- curl, cola, poly, etc. I'm not too familiar with Cujo just yet, so I was having trouble wiring up these new components into the application.

If you have any time, will you take a look? The end goal is removing the need for the lib folder, and instead keeping only the necessary pieces of the application in bower_components. If you're strapped on time, any advice to help me should I try again would be equally appreciated.

Thanks!

(#552)

[briancavalier]

Hey @stephenplusplus, thanks for starting this update! So, the goal would be not to keep cujo libs in the repo, but rather simply to rely on bower to install them? That's cool w/me. I can probably take a look at it tomorrow and see what needs to be done.

[sindresorhus]

So, the goal would be not to keep cujo libs in the repo, but rather simply to rely on bower to install them?

We can't do that yet, as Bower isn't mainstream enough. But we would like it that the included files where the same as the upstream components.

[briancavalier]

@sindresorhus Ok, got it, thanks. Yeah, we can update our impl to use the latest versions of our libs.

[stephenplusplus]

Unrelated, but the response to this "issue" was the speediest, most professional thing I've ever seen. Beers to you guys! 🍻

[briancavalier]

I'm working through this now, and there's not much change required to update to the latest cujo lib releases. I installed them via bower, and tweaked a few little things to account for a few recent changes. I'm planning to clean out "cruft" (like unit tests, docs, etc.) from the libs and then send a PR.

Had a question tho: Seems that bower 0.9.2 currently wants to install into a dir named components rather than bower_components. I know we're not ready to depend entirely on bower for todomvc, but should I include a .bowerrc that sets "directory": "bower_components", or should I just not worry about it? Thanks!

[stephenplusplus]

There was a Bower issue and a follow-up PR about that a couple weeks ago. As far as I know, the plan is still to convert components to bower_components, it's just a matter of how soon it's actually coming. I know there's a rewrite going on over at Bower, so maybe they're waiting on that release to introduce the change.

The other examples currently don't have a .bowerrc pointing to bower_components, so I think it's safe to leave that file out, assuming bower_components will be the default installation directory soon.

@sindresorhus @passy might know more?

[briancavalier]

@stephenplusplus Great, thanks. I'll assume that I shouldn't add .bowerrc, unless @sindresorhus or @passy follow up with other instructions.

[briancavalier]

Our jshint config for cujoJS libs is different from the one being used to validate todomvc impls. It seems like the right thing to do is for us to make our application code pass the todomvc jshint, but obviously maintain our own jshint conventions in the cujoJS libs. I'm totally cool with that if you guys are.

[stephenplusplus]

Yep, that's all that's expected :)

[briancavalier]

Excellent. I believe we're code complete on this, just going to let other cujoJS'ers take a review pass on it and then send the PR.

[sindresorhus]

No need for .bowerrc and yes to jshint comment.