fix(job-scheduler): add next delayed job only when prevMillis matches with producerId #3001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
commented
Jan 9, 2025
| schedulerAttributes[2] or "{}", delayedOpts, timestamp, jobSchedulerId, maxEvents, KEYS[1], nil, nil) | ||
|
|
||
| if ARGV[6] ~= "" then | ||
| rcall("HSET", ARGV[6], "nrjid", nextDelayedJobId) |
There was a problem hiding this comment.
we can even potentially deprecated this attribute with this new validation
roggervalf
force-pushed
the
fix-check-current-producer
branch
from
1e52f79 to
1aabebd
Compare
manast
reviewed
Jan 11, 2025
| ARGV[3] msgpacked delayed opts | ||
| ARGV[4] timestamp | ||
| ARGV[5] prefix key | ||
| ARGV[6] producer key |
There was a problem hiding this comment.
could we use a key here instead of an arg?
roggervalf
force-pushed
the
fix-check-current-producer
branch
from
4ff1399 to
d327bb4
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Jan 12, 2025
## [5.34.9](v5.34.8...v5.34.9) (2025-01-12) ### Bug Fixes * **job-scheduler:** add next delayed job only when prevMillis matches with producerId ([#3001](#3001)) ([4ea35dd](4ea35dd))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
How
Additional Notes (Optional)
Any extra info here.