Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank screen on market closed #60

Open
Eoin-McMahon opened this issue Feb 10, 2021 · 3 comments
Open

Blank screen on market closed #60

Eoin-McMahon opened this issue Feb 10, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@Eoin-McMahon
Copy link

I am not sure if this issue is just me or for everyone, but when the market is closed running a command like:

tickrs -s AAPL 

Results in a blank screen. It would be better to show the activity before market close or to just show a splash screen saying that the market is closed.

Again, this could potentially be a bug isolated to me.

@Eoin-McMahon
Copy link
Author

PS. this tool is awesome, I was going to build something exactly like this in Rust but then i came across this and I don't think i could do it better :D .

@tarkah
Copy link
Owner

tarkah commented Feb 10, 2021

Thanks for opening the issue! Yeah, I think I'll add a "market closed" screen. The time there's no data from the API for intraday is 12am ET to 4am ET once premarket opens.

Feel free to check out the code base and contribute if you'd like!

@tarkah
Copy link
Owner

tarkah commented Feb 10, 2021

This may take me a few days to roll out since I can't really test this until later at night my time. Want to make sure I understand what changes in the API response data as the "day" rolls over. But I am on it!

@tarkah tarkah added the enhancement New feature or request label Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants