feat: block wallets from sending if BN connection stale #5949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
brianp
reviewed
Nov 14, 2023
| .updated | ||
| .ok_or(BaseNodeServiceError::NoChainMetadata)?; | ||
| if Utc::now().naive_utc().timestamp() - last_updated.timestamp() > 15 * 60 { | ||
| return Err(BaseNodeServiceError::NoChainMetadata); |
There was a problem hiding this comment.
Should this error be more specific than NoChainMetadata. Assumedly we have some metadata it's just that we consider it stale.
There was a problem hiding this comment.
maybe.. I thought about it, but still not sure.
block wallet from sending if metadata is old
SWvheerden
force-pushed
the
sw_old_metadata
branch
from
054e3b1 to
5330f96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
block wallet from sending if metadata from base node is stale and older than 15 mins
The console wallet will print out a warning if the connection is stale.
Motivation and Context
Sending via old metadata can cause issues with wallets using old data. The transactions might not be valid anymore
Fixes: #5855