Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cucumber): handles listHeaders response correctly #4551

Merged

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Aug 29, 2022

Description

Motivation and Context

#4515 returns the header in a nested struct, this PR updates the js code to handle that correctly.

How Has This Been Tested?

Pruned node should prune outputs passes

@sdbondi sdbondi force-pushed the cucumber-fix-list-header-usage branch from 121e305 to 8ba322c Compare August 29, 2022 05:43
@sdbondi
Copy link
Member Author

sdbondi commented Aug 29, 2022

This is partially solved in #4552, however there are still cases where the new list headers return structure is not handled - I'll update the code here as needed, which may involve undoing #4552 (as getTipHeader is changed here to return the "non-nested" header). There were also a few other places where getTipHeader return type wasn't changed.

@stringhandler stringhandler merged commit 3958dde into tari-project:development Aug 29, 2022
@sdbondi sdbondi deleted the cucumber-fix-list-header-usage branch August 29, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants