feat: contract acceptance signatures are submitted and validated #4269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
reviewed
Jul 6, 2022
base_layer/core/src/validation/dan_validators/acceptance_validator.rs
Outdated
Show resolved
Hide resolved
sdbondi
reviewed
Jul 7, 2022
applications/tari_validator_node/src/grpc/services/base_node_client.rs
Outdated
Show resolved
Hide resolved
stringhandler
approved these changes
Jul 7, 2022
aviator-app bot
pushed a commit
that referenced
this pull request
Jul 13, 2022
Description --- * feat(base_layer): added proposal acceptance signature validation * refactor(base_layer): DRYing the check of proposal in transaction outputs with a new `output_contains_proposal` function * feat(dan_layer): `AcceptanceManager` now also publishes update proposals, and with the correct signature * fix(integration_test): `proposal_id` value in fixtures is not consistent Motivation and Context --- Proposal acceptances need to be signed by the validator node submitting them. Also, the base layer should validate that the signature is valid. Similar to [recent PRs](#4269), the proposal acceptance signatures follow: `e = H_1(signer_public_key || public_nonce || H_2(contract_id||proposal_id||proposal_commitment))` How Has This Been Tested? --- * New unit test to check the base layer validation of proposal acceptance signatures * For the validation node part, the existing integration test do not raise the signature error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AcceptanceManagerto centralize the creation, signing and submission of contract acceptances. It's used now both for manual and auto acceptances in the validator node.get_current_contract_outputsinBaseNodeClientnow returnUtxoMinedInfoobjects. Needed for retrieving thecommitmentof the contract constitution, used in the acceptance signatureMotivation and Context
Contract acceptances need to be signed by the validator node submitting them. Also, the base layer should validate that the signature is valid.
Similar to recent PRs, the acceptance signatures follow:
e = H_1(signer_public_key || public_nonce || H_2(contract_id||constitution_commitment))How Has This Been Tested?