Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependencies conflicts #118

Closed
wants to merge 2 commits into from
Closed

Fix dependencies conflicts #118

wants to merge 2 commits into from

Conversation

Elishtar
Copy link
Contributor

@Elishtar Elishtar commented Nov 10, 2022 •
edited by ArtDu
Loading

I haven't forgotten about:

  • Tests
  • Changelog
  • Documentation
  • Commit messages comply with the guideline
  • Cleanup the code for review. See checklist

Related issues:

Closes #119

@Elishtar Elishtar force-pushed the fix_debendency_conflicts branch 2 times, most recently from a75b656 to c98859c Compare November 10, 2022 10:03
@Elishtar Elishtar requested a review from ArtDu November 14, 2022 05:57
@ArtDu ArtDu force-pushed the fix_debendency_conflicts branch from 0b0a6bb to 04a4b5c Compare November 16, 2022 14:34
ArtDu and others added 2 commits November 16, 2022 17:37
@ArtDu
Fix debendencies conflicts
580f4e6 
Closes #119

Co-authored-by: am.klyuev <am.klyuev@vk.team>
@ArtDu
Fix build warnings
666bab9
@ArtDu ArtDu force-pushed the fix_debendency_conflicts branch from 04a4b5c to 666bab9 Compare November 16, 2022 14:37
@ArtDu
Copy link
Contributor

ArtDu commented Nov 16, 2022 •
edited
Loading

@Elishtar I can't select you as reviewer. So It's a cause I created new PR #120

@ArtDu ArtDu changed the title Fix debendency conflicts Fix dependencies conflicts Nov 16, 2022
@ArtDu ArtDu closed this Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtDu ArtDu Awaiting requested review from ArtDu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add dependency management
2 participants
@Elishtar @ArtDu