Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Systems Listing react component improvements #40

Open
jchuahtacc opened this issue Jun 4, 2021 · 1 comment
Open

Systems Listing react component improvements #40

jchuahtacc opened this issue Jun 4, 2021 · 1 comment
Assignees
Milestone

Comments

@jchuahtacc
Copy link
Collaborator

jchuahtacc commented Jun 4, 2021

  • Rename the component to SystemList and put it in a subfolder called Systems. (The Systems object from tapis-typescript generates too many naming conflicts, and we can stash any Systems related UI components into a group that way. Like SystemDetail, SystemsList, SystemCredential)
  • Add an onSelect callback property
  • Support firing of onSelect so that the component can allow a user to select a system and a parent component can receive the selection event
  • Add loading indicator when systems are being retrieved
  • Clean up design, possibly using _common components to represent the list with selectable items.
@jchuahtacc jchuahtacc added this to the Systems milestone Jun 4, 2021
@jchuahtacc
Copy link
Collaborator Author

After discussion with @Strmiska:

  • The SystemsList component could be patterned off of the CEPv2 system selector in Data Files:
    image
  • multi-select is not important since nothing takes a set of systems as input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants