Skip to content
This repository was archived by the owner on Oct 6, 2022. It is now read-only.

Move stopForegroundService() to onStop event #294

Merged
merged 1 commit into from
Aug 26, 2019

Conversation

jarredwitt
Copy link
Contributor

@jarredwitt jarredwitt commented Aug 26, 2019

What's this PR does?

Move's the stopForegroundService(); to the onStop event.

Which issue(s) is it related to?

#286

Screenshots (if appropriate)

How to test:

Once change is made perform the following:

  1. Play audio from within App.
  2. Go to either the lock screen or the notifications drawer.
  3. Press the pause button on the music control notification.
  4. Press the play button on the notification (notification should remain the same and continue to update instead of being destroyed).

@tanguyantoine tanguyantoine merged commit e9b4679 into tanguyantoine:master Aug 26, 2019
github-actions bot pushed a commit that referenced this pull request Aug 26, 2019
## [0.10.6](v0.10.5...v0.10.6) (2019-08-26)

### Bug Fixes

* **java:** Move stopForegroundService() to onStop event ([#294](#294)) ([e9b4679](e9b4679))
tothvoj-gl added a commit to EconomistDigitalSolutions/react-native-music-control that referenced this pull request Sep 25, 2019
timmywil pushed a commit to timmywil/react-native-music-control that referenced this pull request Sep 27, 2019
hamy-acg added a commit to hamy-acg/react-native-music-control that referenced this pull request Nov 1, 2019
hamy-acg added a commit to hamy-acg/react-native-music-control that referenced this pull request Nov 1, 2019
stefan-sabau-3pg pushed a commit to equinox-contech/react-native-music-control that referenced this pull request Nov 8, 2019
stefan-sabau-3pg pushed a commit to equinox-contech/react-native-music-control that referenced this pull request Nov 8, 2019
stefan-sabau-3pg pushed a commit to equinox-contech/react-native-music-control that referenced this pull request Nov 8, 2019
## [0.10.6](tanguyantoine/react-native-music-control@v0.10.5...v0.10.6) (2019-08-26)

### Bug Fixes

* **java:** Move stopForegroundService() to onStop event ([tanguyantoine#294](tanguyantoine#294)) ([e9b4679](tanguyantoine@e9b4679))
tanguyantoine pushed a commit that referenced this pull request Oct 12, 2020
## [0.10.6](v0.10.5...v0.10.6) (2019-08-26)

### Bug Fixes

* **java:** Move stopForegroundService() to onStop event ([#294](#294)) ([e9b4679](e9b4679))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants