Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app_name_overrides not applied for "launch" commands #1527

Open
peagha opened this issue Aug 3, 2024 · 1 comment
Open

app_name_overrides not applied for "launch" commands #1527

peagha opened this issue Aug 3, 2024 · 1 comment
Labels
to discuss To discuss in one of the meet-ups

Comments

@peagha
Copy link
Contributor

peagha commented Aug 3, 2024

Hello folks!
first of all congrats on the awesome work you have done with talon and talon community 💟

I have made changes to app_name_overrides and they work with focus commands but it seems to have no support for launch commands. I went through the code and it seems that it was not implemented.

@knausj85 knausj85 added the to discuss To discuss in one of the meet-ups label Nov 30, 2024
@knausj85
Copy link
Member

knausj85 commented Nov 30, 2024

I think the app_switcher is generally in need of a redesign/refactor.

Ideally, I think we would do the following:

  1. On MacOS, parse the Info.plist file for apps and get the bundle identifier / executable. Maybe.
  2. On Windows, attempt to parse the shortcuts in the shell:applications folder to retrieve both the AppUserModelId (required for Windows Store apps) and the target path for the shortcut (ideal for standard apps).

I have not had luck figuring out how to parse the shortcuts yet, but the rest works.

This would allow us to more robustly override these things in both places via

  • bundle name on Mac OS
  • AppUserModelId on Windows
  • executable name or executable path on everything
  • app name on everything

in a robust way. Probably in that order.

If we can't figure out item 2, worst case we could have an entry for both AppUserModelId and the exe

I'm slightly inclined to move away from CSVs for this in favor of something similar to code_languages.py

I don't know how this stuff would translate to linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to discuss To discuss in one of the meet-ups
Projects
None yet
Development

No branches or pull requests

2 participants