Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibly remove cchardet dependency? #19

Open
serixscorpio opened this issue Oct 6, 2022 · 1 comment · May be fixed by #21
Open

Possibly remove cchardet dependency? #19

serixscorpio opened this issue Oct 6, 2022 · 1 comment · May be fixed by #21

Comments

@serixscorpio
Copy link

aiohttp stopped installing cchardet speedup under >Python 3.9 (See aio-libs/aiohttp#6857) due to cchardet being unmaintained. I ran async_scrape/program.py successfully without cchardet using python 3.9 and 3.10. I'll send a PR if it makes sense to remove cchardet from the requirements.txt.

async-techniques-python-course/src/04-asyncio/web_scraping/async_scrape/requirements.txt

Line 5 in dddaba4

cchardet

@mikeckennedy
Copy link
Member

Thanks for the heads up. Yes, send me a PR and I'll gladly accept it.

@serixscorpio serixscorpio linked a pull request Dec 7, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove dependency on cchardet. serixscorpio/async-techniques-python-course
2 participants
@serixscorpio @mikeckennedy