Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React] Multi-select combobox does not support keyboard selection + navigation #1628

Closed
what-is-a-crow opened this issue Jun 29, 2022 · 2 comments · Fixed by #1750
Closed

Comments

@what-is-a-crow
Copy link

What package within Headless UI are you using?

@headlessui/react

What version of that package are you using?

v1.6.5

What browser are you using?

Chrome

Reproduction URL

Use playground-react locally (no changes necessary).

Describe your issue

Steps to reproduce

  1. Run playground-react locally
  2. Open multi-select combobox example in browser
  3. Tab into combobox
  4. Keyboard navigate to an unselected option
  5. Select option by pressing enter
  6. See option is selected (rendered as pill)
  7. Tab away from combobox

Expected behavior

The newly-selected option is preserved as a value.

Actual behavior

The newly-selected option is removed from the values.

@ivaninja
Copy link

ivaninja commented Aug 2, 2022

Any updates on this issue?

@RobinMalfait
Copy link
Member

Hey! Thank you for your bug report!
Much appreciated! 🙏

This should be fixed by #1750, and will be available in the next release. We improved it by just closing the Combobox when using multiple mode without selecting/unselecting the active option.

You can already try it using:

  • npm install @headlessui/react@insiders.
  • npm install @headlessui/vue@insiders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants