Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make dedupe faster at I/O level. #3028

Open
laststylebender14 opened this issue Oct 18, 2024 · 10 comments · May be fixed by #3237
Open

feat: make dedupe faster at I/O level. #3028

laststylebender14 opened this issue Oct 18, 2024 · 10 comments · May be fixed by #3237
Labels
💎 Bounty

Comments

@laststylebender14
Copy link
Contributor

Currently, for all deduplicated requests, we create a clone of the response, but we don't modify the cloned response. This results in redundant copies in memory and unnecessary overhead.

Proposed Solution:

Instead of cloning the response, we can keep a single copy of the response in memory and use it to construct the final response in synth. This approach will optimize both memory usage and performance by reducing duplication and overhead.

A similar approach has been implemented in PR #3025.
@github-actions GitHub Actions
Copy link

Action required: Issue inactive for 30 days.
Status update or closure in 7 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Nov 17, 2024
@github-actions GitHub Actions
Copy link

Issue closed after 7 days of inactivity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 24, 2024
@tusharmath
Copy link
Contributor

/bounty $120

@tusharmath tusharmath reopened this Nov 25, 2024
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Nov 25, 2024 •
edited
Loading

💎 $120 bounty • Tailcall Inc.

Steps to solve:

  1. Start working: Comment /attempt #3028 with your implementation plan
  2. Submit work: Create a pull request including /claim #3028 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

🙏 Thank you for contributing to tailcallhq/tailcall!
🧐 Checkout our guidelines before you get started.
💵 More about our bounty program.

Attempt Started (GMT+0) Solution
🔴 @palash25 Nov 28, 2024, 2:19:17 PM WIP
🔴 @alpha-ulrich Dec 28, 2024, 9:40:38 AM #3237

@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Nov 25, 2024
@palash25
Copy link

palash25 commented Nov 28, 2024 •
edited by algora-pbc bot
Loading

/attempt #3028

Algora profile Completed bounties Tech Active attempts Options
@palash25 2 bounties from 2 projects
Go, Python,
Rust & more
Cancel attempt

palash25 added a commit to palash25/tailcall that referenced this issue Nov 28, 2024
@palash25
dedupe: Use Arc to reduce clones and improve memory usage
e80e77e 
Fixes: tailcallhq#3028
palash25 added a commit to palash25/tailcall that referenced this issue Nov 29, 2024
@palash25
dedupe: Use Arc to reduce clones and improve memory usage
f44e37f 
Fixes: tailcallhq#3028
palash25 added a commit to palash25/tailcall that referenced this issue Nov 29, 2024
@palash25
fix: Use Arc to reduce clones and improve memory usage in dedupe
d9e10e8 
Fixes: tailcallhq#3028
@palash25 palash25 mentioned this issue Nov 29, 2024
Closed
6 tasks
palash25 added a commit to palash25/tailcall that referenced this issue Nov 29, 2024
@palash25
fix: Use Arc to reduce clones and improve memory usage in dedupe
f9def6a 
Fixes: tailcallhq#3028
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Nov 30, 2024

The bounty is up for grabs! Everyone is welcome to /attempt #3028 🙌

@alpha-ulrich
Copy link

alpha-ulrich commented Dec 28, 2024 •
edited by algora-pbc bot
Loading

/attempt #3028

Options

@alpha-ulrich alpha-ulrich mentioned this issue Dec 28, 2024
Closed
6 tasks
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Dec 29, 2024

@alpha-ulrich: Reminder that in 1 days the bounty will become up for grabs, so please submit a pull request before then 🙏

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Dec 30, 2024

The bounty is up for grabs! Everyone is welcome to /attempt #3028 🙌

@alpha-ulrich alpha-ulrich linked a pull request Jan 3, 2025 that will close this issue
Open
6 tasks
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Jan 3, 2025

💡 @alpha-ulrich submitted a pull request that claims the bounty. You can visit your bounty board to reward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💎 Bounty
Projects
None yet
Milestone
No milestone
4 participants
@tusharmath @alpha-ulrich @palash25 @laststylebender14