Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): rework the website hero + animated taiko image #414

Merged
merged 4 commits into from
Dec 14, 2022

Conversation

wolfderechter
Copy link
Contributor

@wolfderechter wolfderechter commented Dec 11, 2022

This is my take on issue #399. I also added an animation on the TaikoGeom image upon scroll, would love to hear thoughts on this but can always be removed. See the picture for how it looks on an Iphone 11 Pro.
Iphone11Pro

@vercel
Copy link

vercel bot commented Dec 11, 2022

@wolfderechter is attempting to deploy a commit to the taikoxyz Team on Vercel.

A member of the Team first needs to authorize it.

@dionysuzx
Copy link
Collaborator

dionysuzx commented Dec 12, 2022

i am seeing a vercel error @wolfderechter , do you know why? this looks great at least from the screenshot, thank you for your contribution! ❤️‍🔥

ReferenceError: window is not defined

EDIT: possibly more info here: https://github.com/taikoxyz/taiko-mono/actions/runs/3669719093/jobs/6203750534

@wolfderechter
Copy link
Contributor Author

There was a problem with the window usage, resolved now

@dionysuzx
Copy link
Collaborator

There was a problem with the window usage, resolved now

this looks awesome, thank you again @wolfderechter ! two small comments:
1: is it possible to brighten the hue / saturation in the default view (scrolled all the way to the top)
brighter/more saturated before:
image
less saturated after:
image

  1. can we put this behind the text? it looks like on mobile view that it goes "in front". also is it possible to make it any smaller on the mobile view / out of the way?

image

@ghost
Copy link

ghost commented Dec 12, 2022 via email

@dionysuzx dionysuzx enabled auto-merge (squash) December 14, 2022 02:52
@dionysuzx dionysuzx merged commit 70087dd into taikoxyz:main Dec 14, 2022
@gitpoap-bot
Copy link

gitpoap-bot bot commented Dec 14, 2022

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 Taiko Contributor:

GitPOAP: 2022 Taiko Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@dionysuzx
Copy link
Collaborator

hi @wolfderechter I noticed there is a gap / overflow on the right side, i'm only noticing this on mobile view. do you know what the fix for it is?

screenshot

image

@wolfderechter
Copy link
Contributor Author

hi @wolfderechter I noticed there is a gap / overflow on the right side, i'm only noticing this on mobile view. do you know what the fix for it is?

screenshot

image

Oh snap, you're right. Just fixed it on #443, there was still an overflow to the right that I overlooked

@dionysuzx
Copy link
Collaborator

hi @wolfderechter I noticed there is a gap / overflow on the right side, i'm only noticing this on mobile view. do you know what the fix for it is?

screenshot

image

Oh snap, you're right. Just fixed it on #443, there was still an overflow to the right that I overlooked

looks like there is a merge conflict @wolfderechter

@github-actions github-actions bot mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants