Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): allow empty L2 blocks #406

Merged
merged 3 commits into from
Dec 9, 2022
Merged

Conversation

davidtaikocha
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #406 (7c40868) into main (742ddcb) will decrease coverage by 0.27%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
- Coverage   65.53%   65.25%   -0.28%     
==========================================
  Files          96       96              
  Lines        2594     2605      +11     
  Branches      310      313       +3     
==========================================
  Hits         1700     1700              
- Misses        827      837      +10     
- Partials       67       68       +1     
Flag Coverage Δ *Carryforward flag
bridge-ui 100.00% <ø> (ø) Carriedforward from 37992fd
protocol 58.68% <14.28%> (-0.47%) ⬇️
relayer 68.34% <ø> (ø) Carriedforward from 37992fd
ui 100.00% <ø> (ø) Carriedforward from 37992fd

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/L1/LibData.sol 21.42% <ø> (ø)
packages/protocol/contracts/L1/v1/V1Proposing.sol 0.00% <0.00%> (ø)
packages/protocol/contracts/L1/v1/V1Proving.sol 0.00% <ø> (ø)
packages/protocol/contracts/L1/v1/V1Utils.sol 0.00% <0.00%> (ø)
packages/protocol/contracts/L1/v1/V1Verifying.sol 18.60% <0.00%> (-0.91%) ⬇️
packages/protocol/contracts/libs/LibTxDecoder.sol 84.53% <100.00%> (+0.16%) ⬆️
...es/protocol/contracts/thirdparty/LibMerkleTrie.sol 90.36% <0.00%> (-1.21%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@davidtaikocha davidtaikocha changed the title feat(protocol): allow empty blocks by updating LibTxDecoder feat(protocol): allow empty blocks ( only contain anchor transactions ) by updating LibTxDecoder Dec 9, 2022
@davidtaikocha davidtaikocha changed the title feat(protocol): allow empty blocks ( only contain anchor transactions ) by updating LibTxDecoder feat(protocol): allow empty blocks (only have one anchor transaction) by updating LibTxDecoder Dec 9, 2022
@davidtaikocha davidtaikocha changed the title feat(protocol): allow empty blocks (only have one anchor transaction) by updating LibTxDecoder feat(protocol): allow empty L2 blocks (only have one anchor transaction) by updating LibTxDecoder Dec 9, 2022
@davidtaikocha davidtaikocha changed the title feat(protocol): allow empty L2 blocks (only have one anchor transaction) by updating LibTxDecoder feat(protocol): allow empty L2 blocks (only contain one anchor transaction) by updating LibTxDecoder Dec 9, 2022
@dantaik dantaik requested a review from cyberhorsey December 9, 2022 15:07
@dantaik dantaik changed the title feat(protocol): allow empty L2 blocks (only contain one anchor transaction) by updating LibTxDecoder feat(protocol): allow empty L2 blocks Dec 9, 2022
@davidtaikocha davidtaikocha merged commit 6d1abf7 into main Dec 9, 2022
@davidtaikocha davidtaikocha deleted the update-decodeTxList branch December 9, 2022 15:56
@github-actions github-actions bot mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants