Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(genesis): support deterministic L2 pre-deployed contract addresses #358

Merged
merged 3 commits into from
Dec 1, 2022

Conversation

davidtaikocha
Copy link
Member

@davidtaikocha davidtaikocha commented Nov 29, 2022

For clients that connecting to our A1 testnet nodes and contracts, deterministic L2 pre-deployed contract addresses can help reducing the trivial works between each re-deployment.

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #358 (bfce1ce) into main (69e9362) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #358   +/-   ##
=======================================
  Coverage   64.57%   64.57%           
=======================================
  Files          88       88           
  Lines        2442     2442           
  Branches      275      275           
=======================================
  Hits         1577     1577           
  Misses        793      793           
  Partials       72       72           
Flag Coverage Δ *Carryforward flag
protocol 60.31% <ø> (ø)
relayer 68.92% <ø> (ø) Carriedforward from 9c72740
ui 100.00% <ø> (ø) Carriedforward from 9c72740

*This pull request uses carry forward flags. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@davidtaikocha davidtaikocha marked this pull request as ready for review November 29, 2022 07:20
@dantaik dantaik requested a review from dionysuzx November 30, 2022 04:45
@davidtaikocha davidtaikocha enabled auto-merge (squash) November 30, 2022 04:57
@dantaik dantaik removed the request for review from dionysuzx December 1, 2022 14:18
@davidtaikocha davidtaikocha merged commit cd34f17 into main Dec 1, 2022
@davidtaikocha davidtaikocha deleted the deterministic-l2-addresses branch December 1, 2022 18:31
@github-actions github-actions bot mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants