Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): add TaikoL1.getBlockProvers #340

Merged
merged 1 commit into from
Nov 26, 2022
Merged

Conversation

davidtaikocha
Copy link
Member

Provers may need to know how many proofs have been submitted for a pending block, and check whether it exceeds TAIKO_MAX_PROOFS_PER_FORK_CHOICE, before submitting the proof.

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #340 (8dfec2b) into main (81aeb1d) will increase coverage by 0.28%.
The diff coverage is 100.00%.

❗ Current head 8dfec2b differs from pull request most recent head e38cdd4. Consider uploading reports for the commit e38cdd4 to get more accurate results

@@            Coverage Diff             @@
##             main     #340      +/-   ##
==========================================
+ Coverage   63.00%   63.29%   +0.28%     
==========================================
  Files          83       83              
  Lines        2449     2452       +3     
  Branches      281      281              
==========================================
+ Hits         1543     1552       +9     
+ Misses        834      827       -7     
- Partials       72       73       +1     
Flag Coverage Δ *Carryforward flag
protocol 58.92% <100.00%> (+0.34%) ⬆️
relayer 69.02% <ø> (+0.21%) ⬆️ Carriedforward from 46eb062

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/L2/V1TaikoL2.sol 56.81% <ø> (ø)
packages/protocol/contracts/L1/TaikoL1.sol 21.27% <100.00%> (+3.49%) ⬆️
...ges/protocol/contracts/libs/LibAnchorSignature.sol 89.47% <0.00%> (-10.53%) ⬇️
packages/relayer/http/routes.go 100.00% <0.00%> (ø)
packages/relayer/http/server.go 96.00% <0.00%> (+2.84%) ⬆️
...es/protocol/contracts/thirdparty/LibMerkleTrie.sol 90.36% <0.00%> (+7.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

dantaik
dantaik previously approved these changes Nov 25, 2022
@davidtaikocha davidtaikocha force-pushed the add-getBlockProvers branch 2 times, most recently from 46eb062 to e38cdd4 Compare November 25, 2022 15:05
@cyberhorsey cyberhorsey merged commit c54f810 into main Nov 26, 2022
@cyberhorsey cyberhorsey deleted the add-getBlockProvers branch November 26, 2022 02:54
@github-actions github-actions bot mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants