Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): fix two occasional errors when running bridge tests #305

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

davidtaikocha
Copy link
Member

@davidtaikocha davidtaikocha commented Nov 22, 2022

Error message:

  10 passing (15s)
  1 failing

  1) integration:Bridge
       processMessage()
         should throw if message has not been received:
     ProviderError: invalid argument 2: hex number > 64 bits
      at HttpProvider.request (node_modules/hardhat/src/internal/core/providers/http.ts:78:19)
      at LocalAccountsProvider.request (node_modules/hardhat/src/internal/core/providers/accounts.ts:188:34)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at async EthersProviderWrapper.send (node_modules/@nomiclabs/hardhat-ethers/src/internal/ethers-provider-wrapper.ts:13:20)

Its because the last parameter in the eth_getStorageAt call here should be a block number but not a block hash:

quantity | tag - Integer block number, or the string 'latest, 'earliest' or 'pending.

@davidtaikocha davidtaikocha marked this pull request as ready for review November 22, 2022 05:40
@davidtaikocha davidtaikocha self-assigned this Nov 22, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #305 (57d1e0c) into main (5c4d370) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
- Coverage   63.81%   63.65%   -0.17%     
==========================================
  Files          81       81              
  Lines        2388     2388              
  Branches      270      270              
==========================================
- Hits         1524     1520       -4     
- Misses        795      800       +5     
+ Partials       69       68       -1     
Flag Coverage Δ *Carryforward flag
protocol 59.77% <ø> (-0.30%) ⬇️
relayer 68.77% <ø> (ø) Carriedforward from c528d67

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...es/protocol/contracts/thirdparty/LibMerkleTrie.sol 83.13% <0.00%> (-7.23%) ⬇️
...ges/protocol/contracts/libs/LibAnchorSignature.sol 100.00% <0.00%> (+10.52%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@davidtaikocha davidtaikocha enabled auto-merge (squash) November 22, 2022 05:46
@davidtaikocha davidtaikocha merged commit fb91e0d into main Nov 22, 2022
@davidtaikocha davidtaikocha deleted the fix-bridge-integration-tests branch November 22, 2022 14:20
@github-actions github-actions bot mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants