-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol): add lastProposedIn
to slotB
#18379
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantaik
added
option.pinned
Will not be marked as stale automatically
option.do-not-merge
meta.breakingABI
labels
Nov 3, 2024
davidtaikocha
approved these changes
Nov 3, 2024
feat(protocol): add
|
Severity Level | Results | |
---|---|---|
Contracts | Critical High Medium Low Note Total |
3 3 0 7 42 55 |
Dependencies | Critical High Medium Low Note Total |
0 0 0 0 0 0 |
For more details view the full report in OpenZeppelin Code Inspector
YoGhurt111
approved these changes
Nov 3, 2024
dantaik
removed
option.pinned
Will not be marked as stale automatically
option.do-not-merge
labels
Nov 4, 2024
This was referenced Nov 4, 2024
YoGhurt111
added a commit
that referenced
this pull request
Nov 5, 2024
This reverts commit 96b380a.
YoGhurt111
added a commit
that referenced
this pull request
Nov 5, 2024
This reverts commit 96b380a.
This was referenced Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
lastProposedIn
to check the last L1 block in which a L2 block is proposed, we can use this field and revert-protection from Blink to conditionally propose blocks. This is a breaking change for taiko-geth as the ABI is changed.