feat(nfts): trailblazer profile picture #18009
Merged
+526
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(nfts): trailblazer profile picture
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
dantaik
approved these changes
Sep 2, 2024
bearni95
requested changes
Sep 2, 2024
bearni95
requested changes
Sep 2, 2024
2manslkh
approved these changes
Sep 2, 2024
bearni95
requested changes
Sep 3, 2024
There was a problem hiding this comment.
Really good progress 🎉 couple final details:
- Include a deployment script
- Ensure
pnpm fmt:solandpnpm lint:solrun clean - Fix the runtime compile warning (seen when running
pnpm testlocally):
Compiler run successful with warnings:
Warning (2519): This declaration shadows an existing declaration.
--> contracts/profile/RegisterProfilePicture.sol:62:9:
|
62 | ProfilePicture memory profilePicture = profilePicture[user];
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Note: The shadowed declaration is here:
--> contracts/profile/RegisterProfilePicture.sol:25:5:
|
25 | mapping(address => ProfilePicture) public profilePicture;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 Taiko Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
This was referenced Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.