Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nfts): kbw party ticket smart contracts #17808

Merged
merged 32 commits into from
Aug 12, 2024
Merged

Conversation

bearni95
Copy link
Contributor

@bearni95 bearni95 commented Jul 17, 2024

  • Basic smart contract implementation
  • Test coverage
  • Deployment scripts
  • NatSpec comments

Contract

  • The contract deployer, admin, orchestrates the sale.
    • The payoutAddress has no admin privileges
  • The contract is unpaused, allowing any user to call mint
  • When the winners are decided, setWinners is called by admin:
    • Contract becomes paused (cannot mint anymore)
    • Winners see their NFTs metadata updated automatically
    • Method isWinner allows checking for tokenId and address individual lookup
  • When paused, admin can call revokeAndReplaceWinner to overwrite the win status of a ticket id for another
  • The method withdraw, only callable by admin and when paused, transfers all the funds to payoutAddress
  • mintWinner method mints a token to the specified to address, and sets it as a raffle winner. Must be called as an admin, and doesn't depend on the contract's pause system.

Copy link

openzeppelin-code bot commented Jul 17, 2024

feat(nfts): kbw party ticket smart contracts

Generated at commit: 6283bfc47f8ec57392f872611bd7e7ef2905a695

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
8
42
54
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@bearni95 bearni95 marked this pull request as ready for review July 30, 2024 09:35
@bearni95 bearni95 requested a review from 2manslkh July 30, 2024 09:45
@bearni95 bearni95 requested a review from dantaik August 7, 2024 12:40
@bearni95 bearni95 requested a review from dantaik August 8, 2024 09:34
@bearni95 bearni95 enabled auto-merge August 9, 2024 08:20
@bearni95 bearni95 added this pull request to the merge queue Aug 12, 2024
Merged via the queue into main with commit 99ec5cb Aug 12, 2024
6 checks passed
@bearni95 bearni95 deleted the kbw-contracts-setup branch August 12, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants