Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(protocol): improve mainnet gas efficiency with addresses cached #17791

Merged
merged 11 commits into from
Jul 14, 2024
Merged

refactor(protocol): improve mainnet gas efficiency with addresses cached #17791

merged 11 commits into from
Jul 14, 2024
+123 −115

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Jul 13, 2024 •
edited
Loading

I realized we can cache depending contracts' addresses this way to avoid one SLOAD of the address manager address and another SLOAD of address manager's impl address.

@davidtaikocha After this PR is merged, we need:

  • upgrade shared address manager using MainnetSharedAddressManager
  • upgrade rollup address manager using MainnetRollupAddressManager
  • upgrade taikoL1 using MainnetTaikoL1
  • deploy and resigter MainnetProverSet and upgrade our prover sets to use this deployment

@dantaik dantaik marked this pull request as ready for review July 13, 2024 13:37
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Jul 13, 2024 •
edited
Loading

feat(protocol): improve mainnet gas efficiency with addresses cached

Generated at commit: 00ba1fa644c70ff2ac3a49b5a4546175a1936c84

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
2
0
8
41
53
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik changed the title feat(protocol): create L1ProverSet, an optimized version of ProverSet feat(protocol): create CachedProverSet, an optimized version of ProverSet Jul 13, 2024
@dantaik dantaik enabled auto-merge July 13, 2024 14:43
@dantaik dantaik changed the title feat(protocol): create CachedProverSet, an optimized version of ProverSet feat(protocol): improve mainnet gas efficiency with addresses cached Jul 14, 2024
@dantaik dantaik changed the title feat(protocol): improve mainnet gas efficiency with addresses cached refactor(protocol): improve mainnet gas efficiency with addresses cached Jul 14, 2024
@dantaik dantaik added this pull request to the merge queue Jul 14, 2024
Merged via the queue into main with commit b12227d Jul 14, 2024
6 checks passed
@dantaik dantaik deleted the prover_set_opt branch July 14, 2024 03:25
@taiko-kitty taiko-kitty mentioned this pull request Jul 12, 2024
Merged
This was referenced Sep 9, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brechtpd Brechtpd Brechtpd approved these changes

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@adaki2004 adaki2004 Awaiting requested review from adaki2004

@smtmfft smtmfft Awaiting requested review from smtmfft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dantaik @Brechtpd @davidtaikocha