feat(protocol): add back EventProcessed event and improve gas logging in Bridge #16760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
feat(protocol): add back EventProcessed event and improve gas logging in Bridge
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
adaki2004
approved these changes
Apr 18, 2024
|
I need the Message added to the event, like in MessageSent, to make the watchdog as reliable/simple as possible. |
Brechtpd
reviewed
Apr 18, 2024
Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com>
dantaik
commented
Apr 19, 2024
Brechtpd
approved these changes
Apr 19, 2024
cyberhorsey
approved these changes
Apr 19, 2024
This was referenced Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cyberhorsey please take a look if this simple event will work for you.
@KorbinianK if you need any change in the protocol, please let me know.