fix(bridge-ui): defaulting to source chain explorer for link to canonical address #16701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorbinianK
approved these changes
Apr 10, 2024
davidtaikocha
approved these changes
Apr 11, 2024
This was referenced Apr 24, 2024
This was referenced May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking out the details of the NFT in the info box, the link taking you to view the NFT details is pointing to the wrong blockchain explorer. For my NFT, it's mistakenly sending me to katla explorer link rather than where it should, the L1 chain explorer. It seems more logical to default to the NFT's source chain explorer link when the NFT hasn't been registered to either the
destTokenVaultContractorsrcTokenVaultContract.Also, in regards to showing the NFT images, most web browsers don't directly support 'IPFS://' links, which might result in many users just seeing placeholder instead of the actual NFT image. Perhaps it would be better a switch to using an IPFS gateway service for these links.
SCREENSHOT: The NFT info box