Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): fix parent metahash check for the first block #16607

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Apr 2, 2024

The check didn't work for block 1 as the genesis block's metahash is 0.

Inspired by code-423n4/2024-03-taiko-findings#218

@dantaik dantaik marked this pull request as ready for review April 2, 2024 11:49
Copy link

openzeppelin-code bot commented Apr 2, 2024

fix(protocol): fix parent metahash check for the first block

Generated at commit: 3229f8092aac5f699abf2fb593c269c8f7af82ce

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
3
39
46
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik added this pull request to the merge queue Apr 3, 2024
Merged via the queue into main with commit ce9e67b Apr 3, 2024
11 checks passed
@dantaik dantaik deleted the parent_metahash_check branch April 3, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants