Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): fix ERC20Airdrop2.sol with an extended withdrawal window #16596

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Apr 2, 2024

code-423n4/2024-03-taiko-findings#245

@adaki2004 Dani, please take a look at the bug report above...

OR we simply delete this contract if ERC20Airdrop is to be used by genesis airdop.

Copy link

openzeppelin-code bot commented Apr 2, 2024

fix(protocol): fix ERC20Airdrop2.sol with an extended withdrawal window

Generated at commit: 0013c194536ed2395060d5e0a266819c57948176

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
3
39
46
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@adaki2004
Copy link
Contributor

code-423n4/2024-03-taiko-findings#245

@adaki2004 Dani, please take a look at the bug report above...

OR we simply delete this contract if ERC20Airdrop is to be used by genesis airdop.

Well, we haven't paid too much attention to version 2, because v1 will be used with genesis. But Trailblazer could still use this type and personally i think it should !
(Will adjust the failing test).

@dantaik dantaik changed the title fix(protocol): fix ERC20Airdrop2.sol? fix(protocol): fix ERC20Airdrop2.sol with an extended withdrawal window Apr 3, 2024
@dantaik dantaik marked this pull request as ready for review April 3, 2024 01:43
@dantaik dantaik added this pull request to the merge queue Apr 3, 2024
Merged via the queue into main with commit bc542d8 Apr 3, 2024
10 checks passed
@dantaik dantaik deleted the ERC20Airdrop2_fix branch April 3, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants