Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol): avoid proving-fee payment if amount is 0 #16595

Merged
merged 3 commits into from
Apr 3, 2024
Merged

feat(protocol): avoid proving-fee payment if amount is 0 #16595

merged 3 commits into from
Apr 3, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Apr 2, 2024 •
edited
Loading

This is mainly for gas optimization.

@dantaik dantaik marked this pull request as ready for review April 2, 2024 03:52
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Apr 2, 2024 •
edited
Loading

feat(protocol): avoid proving-fee payment if amount is 0

Generated at commit: 59d621a00ee0ae4725b0e09fd5cfaa481092dc35

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
2
0
3
39
46
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik mentioned this pull request Apr 2, 2024
Closed
@dantaik dantaik enabled auto-merge April 2, 2024 16:20
@dantaik dantaik added this pull request to the merge queue Apr 3, 2024
Merged via the queue into main with commit 761a066 Apr 3, 2024
10 checks passed
@dantaik dantaik deleted the avoid_fee_payment_if_amount_is_0 branch April 3, 2024 01:15
This was referenced Apr 3, 2024
Merged
Closed
@taiko-kitty taiko-kitty mentioned this pull request Apr 10, 2024
Closed
@taiko-kitty taiko-kitty mentioned this pull request Apr 25, 2024
Closed
@taiko-kitty taiko-kitty mentioned this pull request May 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brechtpd Brechtpd Brechtpd approved these changes

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@adaki2004 adaki2004 Awaiting requested review from adaki2004

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dantaik @Brechtpd @davidtaikocha