feat(relayer): unprofitable queue + use txmgr #16505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cyberhorsey
requested review from
dantaik,
davidtaikocha,
xiaodino and
RogerLamTd
and removed request for
dantaik
cyberhorsey
changed the title
davidtaikocha
approved these changes
Mar 26, 2024
RogerLamTd
reviewed
Mar 26, 2024
RogerLamTd
reviewed
Mar 26, 2024
Co-authored-by: Roger <50648015+RogerLamTd@users.noreply.github.com>
Co-authored-by: Roger <50648015+RogerLamTd@users.noreply.github.com>
xiaodino
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new queue for unprofitable messages, and updates our tx sender to use the same on as the new taiko-client.
It is likely on Mainnet, we will have messages that are unprofitable to process. We don't want to discard these messages, nor do we want to process them and lose money. Intead, we should publish them to a queue to "sit and die" for a little bit. A delayed Queue.
Then, when they expire in that queue, they should be re-routed to the original queue via a dead-letter mechanism, to see if they are yet profitable, and enter the normal workflow of message processing again.
It also adds new metrics to track this.
This has been deployed onto our latest internal devnet as well.