fix(bridge-ui): correct display of forward arrow and handling of invalid pagination input #16485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…page and handle input of number greater than total pages.
…page. Previously, the forward arrow button was incorrectly displayed even beyond the last page. Also, when users input a number greater than the total number of pages in the pagination input field, the application would attempt to navigate to the specified page, leading to unexpected behavior. This commit addresses this issue.
…page. Previously, the forward arrow button was incorrectly displayed even beyond the last page. Also, when users input a number greater than the total number of pages in the pagination input field, the application would attempt to navigate to the specified page, leading to unexpected behavior. This commit addresses this issue.
|
@KorbinianK, Sorry, I was having so many issues to fix the lint error. So I had to delete the repo and start afresh. Hopefully it works okay now. |
courage-ugwuanyi
changed the title
1 task
|
@courage-ugwuanyi it still fails when linting. Run |
@KorbinianK Please check if it works now. Thanks |
KorbinianK
approved these changes
Mar 20, 2024
xiaodino
approved these changes
Mar 21, 2024
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 Taiko Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
This was referenced Apr 24, 2024
This was referenced May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses:
A bug related to pagination in the transactions page. Previously, the forward arrow button was incorrectly displayed even beyond the last page, leading to confusion for users. This bug has been fixed to ensure that the forward arrow button is displayed only when there are additional pages to navigate to.
Previously, when users input a number greater than the total number of pages in the pagination input field, the application would attempt to navigate to the specified page, leading to unexpected behaviour. This commit addresses this issue by adding validation in the handleKeydown function to check if the input number exceeds the total number of pages. If the input is invalid, the application ignores the input and does nothing.
Changes:
How to Test:
closes #16468