fix(protocol): remove the blob-reuse feature #16439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As discussed offline, we dont need the blob-resue if we:
|
adaki2004
approved these changes
Mar 14, 2024
davidtaikocha
approved these changes
Mar 14, 2024
dantaik
changed the title
This was referenced Mar 29, 2024
dantaik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on our discussion in the previous all-hands, it seems reuse-blob is not a feature that we will use.
Also removed the txListSize from Block metadata as it is not necessary and not used by the client at all.
BEGIN_COMMIT_OVERRIDE
fix(protocol): remove the blob-reuse feature
END_COMMIT_OVERRIDE