Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): fix bridge prove message issue using staticcall #16404

Merged
merged 6 commits into from
Mar 12, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Mar 12, 2024

Previously proveSignalReceived in signalService is a view function, but now it can cache data so it's no longer a view function. Therefore, in Bridge.sol, we can no longer use staticcall.

@dantaik dantaik marked this pull request as ready for review March 12, 2024 02:44
@adaki2004
Copy link
Contributor

Previously proveSignalReceived in signalService is a view function, but now it can cache data so it's no longer a view function. Therefore, in Bridge.sol, we can no longer use staticcall.

How could it work even on an internal devnet ? Or simply we never cached the data, that was it ?

@dantaik
Copy link
Contributor Author

dantaik commented Mar 12, 2024

Previously proveSignalReceived in signalService is a view function, but now it can cache data so it's no longer a view function. Therefore, in Bridge.sol, we can no longer use staticcall.

How could it work even on an internal devnet ? Or simply we never cached the data, that was it ?

The relayer did not enable caching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants