feat(protocol): risc0 verifier contract #16331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantaik
reviewed
Mar 6, 2024
dantaik
reviewed
Mar 6, 2024
dantaik
reviewed
Mar 6, 2024
dantaik
reviewed
Mar 6, 2024
dantaik
reviewed
Mar 6, 2024
dantaik
reviewed
Mar 6, 2024
dantaik
reviewed
Mar 6, 2024
dantaik
requested changes
Mar 6, 2024
d1onys1us
reviewed
Mar 6, 2024
dantaik
requested changes
Mar 7, 2024
dantaik
requested changes
Mar 7, 2024
packages/protocol/contracts/verifiers/libs/LibPublicInputHash.sol
Outdated
Show resolved
Hide resolved
dantaik
reviewed
Mar 8, 2024
dantaik
reviewed
Mar 8, 2024
packages/protocol/contracts/thirdparty/risczero/IRiscZeroReceiptVerifier.sol
Show resolved
Hide resolved
dantaik
reviewed
Mar 8, 2024
dantaik
requested changes
Mar 8, 2024
dantaik
approved these changes
Mar 11, 2024
Brechtpd
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
We'll have some actual proofs to test with any moment now. Should we also copy the actual verification code in the test folder for testing so we can completely verify everything is correct without having to deploy on some testnet? Or it's too much of a hassle to get the necessary contracts working in our repo for that?
This was referenced Mar 12, 2024
This was referenced Mar 29, 2024
This was referenced Apr 5, 2024
This was referenced Apr 24, 2024
This was referenced May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Brechtpd let me know please what is missing ! (Beside tests).