Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): enforce initializer call with onlyInitializing modifier #16061

Merged
merged 7 commits into from
Feb 25, 2024

Conversation

arularmstrong
Copy link
Contributor

This PR strengthens code security by adding the onlyInitializing modifier to several init methods, ensuring they are called only from functions with an initializer modifier. Additionally, it improves code clarity by directly importing Initializable rather than relying on child inheritance. These changes enhance contract integrity and maintainability.

The init methods lacking the onlyInitializing modifier are as follows:

  1. __AddressResolver_init()
  2. __Essential_init()
  3. __OwnerUUPSUpgradable_init()
  4. __CrossChainOwned_init()
  5. __MerkleClaimable_init()

@dantaik dantaik requested a review from adaki2004 February 25, 2024 10:42
@dantaik dantaik added this pull request to the merge queue Feb 25, 2024
Merged via the queue into taikoxyz:main with commit f3d7d82 Feb 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants