feat(protocol): extend SignalService interface #15969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantaik
reviewed
Feb 21, 2024
|
🚨👮♂️ |
dantaik
changed the title
dantaik
reviewed
Feb 21, 2024
Co-authored-by: Daniel Wang <99078276+dantaik@users.noreply.github.com>
dantaik
reviewed
Feb 21, 2024
dantaik
approved these changes
Feb 21, 2024
davidtaikocha
approved these changes
Feb 21, 2024
This was referenced Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@KorbinianK @cyberhorsey
You can query if we need to have ful proof or not if calling:
getSyncedChainData(cahinId,LibSignals.SIGNAL_ROOT,blockId)If you supply 0 for blockId, it will return you the
topBlockIdwhere theLibSignals.SIGNAL_ROOTwas cached and you dont need to have full proof (for that block height!).If you supply non-0 for blockId, it will specifically search for that block id and revert if not cached.