feat(bridge-ui-v2): navigation support to swap-ui from bridge-ui #15922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arularmstrong Thanks, very good idea. Please fix the linting issues then we can merge it. Run |
|
Sure, fixing the lint issues. |
|
@KorbinianK lint issues are resolved, |
|
make sure to add |
KorbinianK
approved these changes
Feb 19, 2024
KorbinianK
requested review from
d1onys1us,
dantaik,
davidtaikocha and
xiaodino
|
@arularmstrong approved. But please note, that the changes won't be visible before our next bridge release. |
dantaik
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a navigation bar for
swapfrom the Bridge UI, enabling seamless navigation between two apps. Notably, while a redirect from the Swap UI to the Bridge UI already exists, this update addresses the lack of a reciprocal link and ensures improved user experience and navigation consistency.reference on swap-ui
reference on bridge-ui
