revert(protocol): revert update open-zeppelin contracts

[dionysuzx]

…58)"

This reverts commit 4b5a95a.

Summary by CodeRabbit

• New Features
  • Implemented additional governance modules for enhanced contract functionality.
• Refactor
  • Simplified the supportsInterface function and removed the cancel function in the governance contract.
  • Updated governance contract initialization and execution logic for better clarity and efficiency.
• Tests
  • Improved test clarity by renaming the return value of the name() function in governance contract tests.
  • Revised testing logic for admin role access and restrictions in essential contract tests.

[coderabbitai]

Walkthrough

The updates involve enhancing the TaikoGovernor smart contract by integrating more governance modules from OpenZeppelin, refining governance functions, and improving clarity in naming. Additionally, adjustments in testing files reflect these updates and further refine access control mechanisms, aiming for a more secure and transparent governance process.

Changes

File Path	Change Summary
.../L1/gov/TaikoGovernor.sol	- Imported additional OpenZeppelin modules - Updated initialization and execution functions - Simplified interface support - Removed cancel function
.../test/L1/gov/TaikoGovernor.t.sol	- Changed name() function return value to "TaikoGovernor"
.../test/common/EssentialContract.t.sol	- Removed _ADMIN_SLOT, updated admin() access logic

🐰🎉
Changes afoot, in code we trust,
Governance refined, upgrades a must.
Through lines of solidity, we adjust and tune,
For a blockchain that's secure, under the digital moon.
Let's hop to it, with code so bright,
In the world of smart contracts, we ignite the light. 🌟🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 4b5a95a and 48e1bdf.

Files ignored due to path filters (2)

• packages/protocol/package.json is excluded by: !**/*.json
• pnpm-lock.yaml is excluded by: !**/*.yaml

Files selected for processing (3)

• packages/protocol/contracts/L1/gov/TaikoGovernor.sol (5 hunks)
• packages/protocol/test/L1/gov/TaikoGovernor.t.sol (1 hunks)
• packages/protocol/test/common/EssentialContract.t.sol (2 hunks)

Additional comments: 3

packages/protocol/contracts/L1/gov/TaikoGovernor.sol (2)

• 17-20: The addition of multiple OpenZeppelin governance modules (GovernorUpgradeable, GovernorCompatibilityBravoUpgradeable, GovernorVotesUpgradeable, GovernorVotesQuorumFractionUpgradeable, and GovernorTimelockControlUpgradeable) significantly enhances the governance capabilities of the TaikoGovernor contract. This modular approach allows for a flexible and upgradable governance system. Ensure that the integration of these modules aligns with the project's governance requirements and that the initialization of these modules in the init function is correctly configured.
• 71-71: The simplification of the supportsInterface function by directly returning the super.supportsInterface(interfaceId) call is a clean and efficient way to handle interface support checks. This approach maintains clarity and reduces the potential for errors by leveraging the inherited functionality from the OpenZeppelin contracts.

packages/protocol/test/L1/gov/TaikoGovernor.t.sol (1)

• 94-94: Updating the name() function's return value from "Taiko" to "TaikoGovernor" in the test suite enhances clarity and aligns the test's expectations with the contract's identity. This change is a good practice for maintaining clear and understandable test cases.