fix(protocol): allow proposing when proving is paused

[Brechtpd]

Sorry I introduced this in #15740

Summary by CodeRabbit

• New Features
  • Enhanced block verification process with conditional checks based on the contract state.
• Bug Fixes
  • Improved fee calculation logic for better handling of payments to provers in both Ether and ERC20 tokens.

[coderabbitai]

Warning

Rate Limit Exceeded

@dantaik has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 18 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 89186a1 and effe747.

Walkthrough

This update introduces a conditional check in the TaikoL1.sol contract to verify blocks based on the provingPaused state and modifies the fee calculation logic in the AssignmentHook.sol contract. These changes aim to enhance the system's flexibility and fee management, aligning with broader objectives to improve the proof system's adaptability and openness.

Changes

File Path	Change Summary
.../L1/TaikoL1.sol	Added a conditional check to verify blocks based on provingPaused state.
.../L1/hooks/AssignmentHook.sol	Modified logic for calculating totalFeeETH by removing the direct addition of proverFee.

Related issues

• feat(protocol): Open multi-proof for Proposer & Prover #15413: The changes in this PR could support the objective of simplifying proving fee calculation by making the proof type more deterministic, which aligns with the issue's aim to enhance the proof system's flexibility and adaptability.

Poem

In the realm of code where smart contracts thrive,
A rabbit hopped in, making blockchain alive.
With every tweak and change, it danced,
Ensuring that Taiko's proof system advanced.
🌟 "To a future bright," it did cheer,
Where proving's pause and fees are clear.
🐰 CodeRabbit, with wisdom so wide,
Celebrates the journey, hopping side by side.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 136bdb7 and 89186a1.

Files selected for processing (2)

• packages/protocol/contracts/L1/TaikoL1.sol (1 hunks)
• packages/protocol/contracts/L1/hooks/AssignmentHook.sol (1 hunks)

Additional comments: 2

packages/protocol/contracts/L1/hooks/AssignmentHook.sol (1)

• 109-115: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [83-85]

The conditional check to proceed with block verification only if provingPaused is false is correctly implemented. This ensures that block verification is skipped during proving pauses, aligning with the PR's objectives.

packages/protocol/contracts/L1/TaikoL1.sol (1)

• 80-88: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-152]

The AssignmentHook.sol contract correctly implements the logic for handling prover assignments and fee processing. The code correctly determines the proverFee based on tier fees and handles payments to the assigned prover in either Ether or ERC20 tokens. While the specific change related to the removal of proverFee addition to totalFeeETH is not directly annotated, the overall logic and implementation of fee handling appear sound and align with the PR's objectives.