fix(bridge-ui-v2): fixed fee selection modal bugs

[paulallensuxs]

Description

This pull request introduces fixes to the fee selection modal for the bridge. It addresses the issue where selecting a custom fee, then switching to the recommended or zero fee, and subsequently cancelling the modal resulted in random fee selections. Additionally, it fixes a bug where the custom selected fee could incorrectly be set to the written fee after canceling modal and then reset to zero after a delay. Furthermore, it allows users to set a zero fee by entering '0' in the custom fee field and defaults to the recommended fee if the input box is left empty.

Changes Made

• Implemented a temporary variable tempProcessingFeeMethod to store the current processing fee method, ensuring the selected fee method does not change until confirmed by the user.
• Introduced a tempprocessingFee to capture the input value and prevent it from affecting the actual fee until confirmation.
• Added the confirmChanges function called only when the confirmation button is pressed.
• Updated the inputProcessFee event and various bindings to reference tempProcessingFeeMethod and tempprocessingFee for accurate state capture during user interaction.

Testing

The fixes have been thoroughly tested under various scenarios to ensure the modal behaves as expected. The following cases have been tested:

• Setting a custom fee and then selecting recommended and cancelling retains the previously selected fee method.
• Setting a custom fee and then selecting zero fee and cancelling retains the previously selected fee method.
• Setting a custom fee to zero and confirming now accurately sets the fee to zero.
• Setting a custom fee and then writing another fee and pressing cancel to check if cancelled custom fee doesn't get set.
• Leaving the custom fee input empty and confirming defaults to the recommended fee.

Video Demonstrations

Fee Selection & Cancellation Bug	Custom Fee Retention Bug

[KorbinianK]

@paulallensuxs Thanks for this high quality PR! Approved!

Just in case, we do not (yet) have a Git POAP for 2024, but Github tracks contributions ;)

[coderabbitai]

Warning

Rate Limit Exceeded

@dantaik has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 24 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 6c7e4de and e05847c.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.