feat(protocol): check if addresses ever reregistered in SGXProver #15665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adaki2004
changed the title
dong77
reviewed
Feb 6, 2024
dantaik
approved these changes
Feb 6, 2024
dantaik
changed the title
dantaik
changed the title
Brechtpd
approved these changes
Feb 6, 2024
This was referenced Feb 9, 2024
Closed
This was referenced Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One address shall be registered (during attestation) only once, otherwise it could bypass this contract's expiry check by always registering with the same attestation and getting multiple valid
instanceIds.While during proving, it is technically possible to register the old addresses, it is less of a problem, because the
instanceIdwould be the same for those addresses and can be easily deleted without the possibility of re-registering again - while if we dont rate limit at registration level, it could shoot up legit (and same) sgx provers with differentinstanceIds.