fix(protocol): Use safeMint with ERC721 #15636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adaki2004
commented
Feb 1, 2024
adaki2004
commented
- Better to use safeMint() with ERC721 as _checkOnERC721Received will be called after token transferred. It ensures if the recipient is a contract, it is indeed designed to receive ERC721 tokens.
- Comment mismatch with code.
adaki2004
requested review from
dantaik and
Brechtpd
and removed request for
dantaik
Brechtpd
approved these changes
Feb 1, 2024
dantaik
approved these changes
Feb 2, 2024
This was referenced Feb 9, 2024
Closed
This was referenced Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.