fix(protocol): Correct decoding (TKO-03) #15582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adaki2004
commented
Jan 26, 2024
adaki2004
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adaki2004
changed the title
Brechtpd
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
General question: do we need recall? It seems like a complex thing, also complex to test, and a source of multiple bugs presumably also because it's hard to test and not being used.
So do we think it is just a nice to have? Do we think it's something critical that will actually be used? I'm just trying to find out if this feature makes sense from a risk/reward point of view because the bridge itself is so critical for security, the reward really needs to be worth the risk.
dantaik
approved these changes
Jan 26, 2024
This was referenced Feb 9, 2024
Closed
This was referenced Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.