Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(protocol): use safeTransferFrom (TKO-09) #15567

Merged
merged 6 commits into from
Jan 26, 2024
Merged

fix(protocol): use safeTransferFrom (TKO-09) #15567

merged 6 commits into from
Jan 26, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Jan 25, 2024

Screenshot 2024-01-25 at 19 27 12

@dantaik dantaik requested a review from adaki2004 January 25, 2024 11:27
@vercel Vercel
Copy link

vercel bot commented Jan 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
bridge-ui-v2-a6 ✅ Ready (Inspect) Visit Preview Jan 26, 2024 5:51am

@dantaik
Copy link
Contributor Author

dantaik commented Jan 25, 2024

Screenshot 2024-01-25 at 20 17 42

@adaki2004 not sure for USDC adaptor, whether we should use safeTransferFrom as well. Do you remember where we get this IUSDC interface?

@dantaik dantaik marked this pull request as ready for review January 25, 2024 12:18
@dantaik dantaik requested a review from Brechtpd January 25, 2024 12:19
@adaki2004
Copy link
Contributor

adaki2004 commented Jan 25, 2024 •
edited
Loading

Screenshot 2024-01-25 at 20 17 42

@adaki2004 not sure for USDC adaptor, whether we should use safeTransferFrom as well. Do you remember where we get this IUSDC interface?

No need action here either, because i think this is an invalid comment from SigmaPrime (related to USDC). They follow the standard of IERC20 and returns a bool.
kép

I think they mixed it up with USDT, which indeed does not return true. Will ask them in the chat.

@adaki2004
Copy link
Contributor

Screenshot 2024-01-25 at 20 17 42 @adaki2004 not sure for USDC adaptor, whether we should use safeTransferFrom as well. Do you remember where we get this IUSDC interface?

No need action here either, because i think this is an invalid comment from SigmaPrime (related to USDC). They follow the standard of IERC20 and returns a bool. kép

I think they mixed it up with USDT, which indeed does not return true. Will ask them in the chat.

@dantaik Kirk confirmed (see telegram), he mixed it with USDT, all good, can stay as is, as USDC follows the standard.

@dantaik dantaik requested a review from Brechtpd January 26, 2024 05:50
@dantaik dantaik requested a review from davidtaikocha January 26, 2024 07:26
@dantaik dantaik enabled auto-merge January 26, 2024 13:52
@dantaik dantaik removed the request for review from davidtaikocha January 26, 2024 13:52
@dantaik dantaik disabled auto-merge January 26, 2024 13:52
@dantaik dantaik enabled auto-merge January 26, 2024 13:52
@dantaik dantaik added this pull request to the merge queue Jan 26, 2024
Merged via the queue into alpha-6 with commit 30d771c Jan 26, 2024
14 checks passed
@dantaik dantaik deleted the safe_transfer_from branch January 26, 2024 13:53
This was referenced Feb 9, 2024
Closed
Merged
@taiko-kitty taiko-kitty mentioned this pull request Mar 1, 2024
Closed
@taiko-kitty taiko-kitty mentioned this pull request Mar 29, 2024
Closed
This was referenced Apr 5, 2024
Closed
Closed
@taiko-kitty taiko-kitty mentioned this pull request Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adaki2004 adaki2004 adaki2004 approved these changes

@Brechtpd Brechtpd Brechtpd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dantaik @adaki2004 @Brechtpd