fix(protocol): Non-recursive abi.encode for Zk Verifier #15344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CeciliaZ030 is attempting to deploy a commit to the taikoxyz Team on Vercel. A member of the Team first needs to authorize it. |
CeciliaZ030
changed the title
davidtaikocha
changed the title
davidtaikocha
approved these changes
Dec 7, 2023
dong77
approved these changes
Dec 7, 2023
dantaik
approved these changes
Dec 7, 2023
KorbinianK
added a commit
that referenced
this pull request
Dec 14, 2023
commit 7dfc298 Author: Daniel Wang <dan@taiko.xyz> Date: Tue Dec 12 16:46:17 2023 +0800 add links in solidity files commit 0ece27d Author: Korbinian <KorbinianK@users.noreply.github.com> Date: Mon Dec 11 21:59:02 2023 +0100 chore(bridge-ui-v2): update and fix typescript-linting (#15372) commit 9ef2dd2 Author: Daniel Wang <99078276+dantaik@users.noreply.github.com> Date: Mon Dec 11 19:47:30 2023 +0800 refactor(protocol): use Bridge to send cross-chain owned contract transactions (#15368) Co-authored-by: David <david@taiko.xyz> commit 5e06cd9 Author: xiaodino <ruby@taiko.xyz> Date: Mon Dec 11 00:35:00 2023 -0800 feat(bridge-ui-v2): Update encoded signal proof in BridgeProver.ts (#15348) Co-authored-by: David <david@taiko.xyz> Co-authored-by: Daniel Wang <99078276+dantaik@users.noreply.github.com> commit 8edcb3c Author: Daniel Wang <99078276+dantaik@users.noreply.github.com> Date: Mon Dec 11 15:17:52 2023 +0800 chore(protocol): move eip1559_util.py to script/ (#15367) commit 161f4c6 Author: Daniel Wang <99078276+dantaik@users.noreply.github.com> Date: Fri Dec 8 16:47:54 2023 +0800 feat(protocol): Use taikoL2's address as the treasury address in circuits (#15350) Co-authored-by: David <david@taiko.xyz> commit d50b276 Author: David <david@taiko.xyz> Date: Fri Dec 8 13:51:32 2023 +0800 feat(protocol): grant `securityCouncil` the `PROPOSER` role (#15355) commit 75b2ef9 Author: jeff <113397187+cyberhorsey@users.noreply.github.com> Date: Thu Dec 7 19:02:42 2023 -0800 feat(guardian-prover-health-check): ui + api (#15324) commit 06ce873 Author: Daniel Wang <99078276+dantaik@users.noreply.github.com> Date: Thu Dec 7 16:01:42 2023 +0800 chore(protocol): apply fixes based on OZ's inspector reports (#15320) commit 8fc51b4 Author: CeciliaZ030 <45245961+CeciliaZ030@users.noreply.github.com> Date: Thu Dec 7 05:32:31 2023 +0300 fix(protocol): Non-recursive abi.encode for Zk Verifier (#15344)
KorbinianK
added a commit
that referenced
this pull request
Dec 14, 2023
commit 97f83f0 Author: jeff <113397187+cyberhorsey@users.noreply.github.com> Date: Tue Dec 12 18:19:35 2023 -0800 feat(guardian-prover-health-check): Guardian prover metrics (#15377) commit 975c882 Author: jeff <113397187+cyberhorsey@users.noreply.github.com> Date: Tue Dec 12 06:06:50 2023 -0800 feat(guardian-prover-health-check): Guardian prover rework (#15375) commit 7dfc298 Author: Daniel Wang <dan@taiko.xyz> Date: Tue Dec 12 16:46:17 2023 +0800 add links in solidity files commit 0ece27d Author: Korbinian <KorbinianK@users.noreply.github.com> Date: Mon Dec 11 21:59:02 2023 +0100 chore(bridge-ui-v2): update and fix typescript-linting (#15372) commit 9ef2dd2 Author: Daniel Wang <99078276+dantaik@users.noreply.github.com> Date: Mon Dec 11 19:47:30 2023 +0800 refactor(protocol): use Bridge to send cross-chain owned contract transactions (#15368) Co-authored-by: David <david@taiko.xyz> commit 5e06cd9 Author: xiaodino <ruby@taiko.xyz> Date: Mon Dec 11 00:35:00 2023 -0800 feat(bridge-ui-v2): Update encoded signal proof in BridgeProver.ts (#15348) Co-authored-by: David <david@taiko.xyz> Co-authored-by: Daniel Wang <99078276+dantaik@users.noreply.github.com> commit 8edcb3c Author: Daniel Wang <99078276+dantaik@users.noreply.github.com> Date: Mon Dec 11 15:17:52 2023 +0800 chore(protocol): move eip1559_util.py to script/ (#15367) commit 161f4c6 Author: Daniel Wang <99078276+dantaik@users.noreply.github.com> Date: Fri Dec 8 16:47:54 2023 +0800 feat(protocol): Use taikoL2's address as the treasury address in circuits (#15350) Co-authored-by: David <david@taiko.xyz> commit d50b276 Author: David <david@taiko.xyz> Date: Fri Dec 8 13:51:32 2023 +0800 feat(protocol): grant `securityCouncil` the `PROPOSER` role (#15355) commit 75b2ef9 Author: jeff <113397187+cyberhorsey@users.noreply.github.com> Date: Thu Dec 7 19:02:42 2023 -0800 feat(guardian-prover-health-check): ui + api (#15324) commit 06ce873 Author: Daniel Wang <99078276+dantaik@users.noreply.github.com> Date: Thu Dec 7 16:01:42 2023 +0800 chore(protocol): apply fixes based on OZ's inspector reports (#15320) commit 8fc51b4 Author: CeciliaZ030 <45245961+CeciliaZ030@users.noreply.github.com> Date: Thu Dec 7 05:32:31 2023 +0300 fix(protocol): Non-recursive abi.encode for Zk Verifier (#15344)
This was referenced Feb 9, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current circuit is not able to handle abi.encode of recursive structs unless the RLP gadget is ready. A few lines of changes in the contract would fix this.