Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge-ui-v2): Add z-index for close button on mobile #14769

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

xiaodino
Copy link
Contributor

The ChainSelect dialogs and some dialogs are not being able to be closed on mobile.

After following https://ymoondhra.medium.com/how-to-run-localhost-on-your-iphone-4110a54d1896 to set up localhost on iPhone, use Safari iPhone web inspector to debug. It should be fixed with this PR.

@vercel
Copy link

vercel bot commented Sep 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bridge-ui-v2-a5 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2023 5:22am
bridge-ui-v2-internal ✅ Ready (Inspect) Visit Preview Sep 21, 2023 5:22am

@KorbinianK
Copy link
Contributor

When you start vite with the --host flag, you can access the local instance in your network :)

@xiaodino xiaodino enabled auto-merge September 21, 2023 07:32
@xiaodino xiaodino added this pull request to the merge queue Sep 21, 2023
Merged via the queue into main with commit 6dff6fc Sep 21, 2023
7 checks passed
@xiaodino xiaodino deleted the xiaodino/fix-chainselect-not-close branch September 21, 2023 08:03
@github-actions github-actions bot mentioned this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants