Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bridge-ui-v2): close dialogs with ESC key #14700

Merged
merged 12 commits into from
Sep 18, 2023
Merged

feat(bridge-ui-v2): close dialogs with ESC key #14700

merged 12 commits into from
Sep 18, 2023

Conversation

KorbinianK
Copy link
Contributor

Some dialogs could not be closed with ESC, some could. Now it should be all of them to be consistent

@KorbinianK KorbinianK self-assigned this Sep 15, 2023
@vercel
Copy link

vercel bot commented Sep 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bridge-ui-v2-a5 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2023 3:13pm
bridge-ui-v2-internal ✅ Ready (Inspect) Visit Preview Sep 18, 2023 3:13pm

@KorbinianK KorbinianK changed the base branch from alpha-5 to main September 15, 2023 15:14
@KorbinianK KorbinianK changed the base branch from main to alpha-5 September 15, 2023 15:15
@KorbinianK KorbinianK marked this pull request as draft September 15, 2023 15:15
@KorbinianK KorbinianK changed the base branch from alpha-5 to main September 15, 2023 19:04
@KorbinianK KorbinianK force-pushed the feat/bridge-ui-v2--close-dialogs-with-esc branch from 929c361 to 33aecc7 Compare September 15, 2023 19:06
@KorbinianK KorbinianK marked this pull request as ready for review September 15, 2023 19:06
dantaik
dantaik previously approved these changes Sep 18, 2023
View reviewed changes
dionysuzx
dionysuzx previously approved these changes Sep 18, 2023
View reviewed changes
davidtaikocha
davidtaikocha previously approved these changes Sep 18, 2023
View reviewed changes
@KorbinianK KorbinianK dismissed stale reviews from davidtaikocha and dionysuzx via a11c1e7 September 18, 2023 15:05
@KorbinianK KorbinianK added this pull request to the merge queue Sep 18, 2023
Merged via the queue into main with commit dbf7a24 Sep 18, 2023
@KorbinianK KorbinianK deleted the feat/bridge-ui-v2--close-dialogs-with-esc branch September 18, 2023 15:07
@github-actions github-actions bot mentioned this pull request Sep 18, 2023
Merged
KorbinianK added a commit that referenced this pull request Sep 19, 2023
@KorbinianK
feat(bridge-ui-v2): close dialogs with ESC key (#14700)
f7226fb
KorbinianK added a commit that referenced this pull request Sep 28, 2023
@KorbinianK
feat(bridge-ui-v2): close dialogs with ESC key (#14700)
3dccdad
KorbinianK added a commit that referenced this pull request Sep 28, 2023
@KorbinianK
feat(bridge-ui-v2): close dialogs with ESC key (#14700)
1837c9e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@dionysuzx dionysuzx dionysuzx approved these changes

@xiaodino xiaodino Awaiting requested review from xiaodino

@dantaik dantaik Awaiting requested review from dantaik

@jscriptcoder jscriptcoder Awaiting requested review from jscriptcoder

Assignees

@KorbinianK KorbinianK

Labels
area.bridge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KorbinianK @jscriptcoder @dionysuzx @dantaik @davidtaikocha