fix(protocol): Remove duplicated events during mint and burn #14686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
davidtaikocha
approved these changes
Sep 13, 2023
davidtaikocha
changed the title
KorbinianK
approved these changes
Sep 13, 2023
Merged
davidtaikocha
pushed a commit
that referenced
this pull request
Sep 14, 2023
2manslkh
pushed a commit
that referenced
this pull request
Sep 14, 2023
KorbinianK
pushed a commit
that referenced
this pull request
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove duplicated events (ERC20Upgradeable already sending them).
See in TXN example: https://sepolia.etherscan.io/tx/0x4e2874dad191489c4397c760ced786713897f322b345e36e4b563f44dc9d9020
It says 2 x 1 TTKOj token transfers:
When I look at the logs, it also says 2 Transfer events:
One is coming from our TaikoToken directly (burn) the other is from ERC20Upgradeable.