-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(relayer): Relayer indexer/processor separation and refactor, messaging queue #14605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
@cyberhorsey does this PR address this issue ? |
Yes, but it's only started today and will be maybe two more days. |
…o-mono into relayer_indexer_separation
dantaik
approved these changes
Sep 6, 2023
dantaik
requested review from
KorbinianK and
xiaodino
and removed request for
dionysuzx and
RogerLamTd
September 6, 2023 07:43
davidtaikocha
approved these changes
Sep 6, 2023
Merged
2manslkh
pushed a commit
that referenced
this pull request
Sep 14, 2023
…saging queue (#14605) Co-authored-by: Daniel Wang <99078276+dantaik@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14528
this PR updates the relayer codebase to be inline with the
taiko-client
architecture, which should make it easier to onboard new people, as well as cross-share work more - once they get familiar with one codebase, they are familiar with all of our Golang applications.It splits the relayer into two separate apps, the
indexer
and theprocessor
, that now communicate asynchronosly through aQueue
interface, the first implementation of which is aRabbitMQ
queue (attached picture, processor is on the left reading from the queue, indexer is on the right listenign to the blockchain and adding to the queue).This has three main advantages:
The main difference is all of the CLI args of the relayer can still be passed in through Environment Variables as well, for easier deployment/configuration.
Latest code is already deployed (matching k8s-config PR is open) to internal-devnet for L1-L2, L2-L1, L2-L3, L3-L2, as well as a RabbitMQ statefulset.
TODO: