Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge-ui): return true if the token address is found on dest chain to send correct gas limit #14446

Merged
merged 13 commits into from
Aug 12, 2023

Conversation

cyberhorsey
Copy link
Contributor

@cyberhorsey cyberhorsey commented Aug 10, 2023

  • fixes network switching by removing the extraneous deffered / switching refactor logic, which doesnt seem to be necessary, and was preventing the page from actually switching the network. This allowed for users to send transactions on wrong networks, and the page to be out of sync with the injected wallet provider.
  • properly detects if a token is bridged already or not, reducing gas limit, which reduces processing fee.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #14446 (f104138) into main (1257568) will decrease coverage by 0.22%.
Report is 2 commits behind head on main.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main   #14446      +/-   ##
==========================================
- Coverage   65.53%   65.31%   -0.22%     
==========================================
  Files          90       89       -1     
  Lines        3160     3140      -20     
  Branches      113      109       -4     
==========================================
- Hits         2071     2051      -20     
  Misses        963      963              
  Partials      126      126              
Flag Coverage Δ *Carryforward flag
bridge-ui 93.91% <83.33%> (-0.14%) ⬇️
eventindexer 44.18% <ø> (ø) Carriedforward from 72e225d
relayer 59.19% <ø> (ø) Carriedforward from 72e225d

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
packages/bridge-ui/src/utils/switchNetwork.ts 100.00% <ø> (ø)
...e-ui/src/utils/checkIfTokenIsDeployedCrossChain.ts 91.66% <83.33%> (+0.36%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

KorbinianK
KorbinianK previously approved these changes Aug 10, 2023
KorbinianK
KorbinianK previously approved these changes Aug 10, 2023
@dantaik dantaik requested a review from xiaodino August 11, 2023 02:54
@dantaik
Copy link
Contributor

dantaik commented Aug 11, 2023

@xiaodino please also review.

@dantaik dantaik added this pull request to the merge queue Aug 12, 2023
Merged via the queue into main with commit 116b902 Aug 12, 2023
3 checks passed
@dantaik dantaik deleted the bridge_ui_fix branch August 12, 2023 06:12
@github-actions github-actions bot mentioned this pull request Aug 12, 2023
dantaik pushed a commit that referenced this pull request Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants