-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bridge-ui): return true if the token address is found on dest chain to send correct gas limit #14446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cyberhorsey
commented
Aug 10, 2023
•
edited
Loading
edited
- fixes network switching by removing the extraneous deffered / switching refactor logic, which doesnt seem to be necessary, and was preventing the page from actually switching the network. This allowed for users to send transactions on wrong networks, and the page to be out of sync with the injected wallet provider.
- properly detects if a token is bridged already or not, reducing gas limit, which reduces processing fee.
…ken address on dest chain is not 0x00
Codecov Report
@@ Coverage Diff @@
## main #14446 +/- ##
==========================================
- Coverage 65.53% 65.31% -0.22%
==========================================
Files 90 89 -1
Lines 3160 3140 -20
Branches 113 109 -4
==========================================
- Hits 2071 2051 -20
Misses 963 963
Partials 126 126
*This pull request uses carry forward flags. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
KorbinianK
previously approved these changes
Aug 10, 2023
KorbinianK
previously approved these changes
Aug 10, 2023
@xiaodino please also review. |
dionysuzx
approved these changes
Aug 11, 2023
KorbinianK
approved these changes
Aug 11, 2023
Merged
dantaik
pushed a commit
that referenced
this pull request
Aug 12, 2023
…in to send correct gas limit (#14446)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.