Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eventindexer): add stats tracking #13810

Merged
merged 7 commits into from
May 25, 2023
Merged

feat(eventindexer): add stats tracking #13810

merged 7 commits into from
May 25, 2023

Conversation

cyberhorsey
Copy link
Contributor

@cyberhorsey cyberhorsey commented May 24, 2023

this PR now tracks blockVerified events, and uses the proofTime and proofReward arguments to maintain an average, and sets us up to calculate other stats we want in the future as well. It exposes them via a /stats endpoint for the status page.

this also updates the status page with the new ABI.

note: this PR relies on code that has not been deployed to alpha-3, Dani's blockVerified event reward and fee changes. so we cant deploy it until we deploy those updates.

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #13810 (bec7d44) into main (ccecd70) will increase coverage by 0.17%.
The diff coverage is 62.00%.

@@            Coverage Diff             @@
##             main   #13810      +/-   ##
==========================================
+ Coverage   47.24%   47.41%   +0.17%     
==========================================
  Files         131      133       +2     
  Lines        3357     3406      +49     
  Branches      310      310              
==========================================
+ Hits         1586     1615      +29     
- Misses       1668     1682      +14     
- Partials      103      109       +6     
Flag Coverage Δ *Carryforward flag
bridge-ui 96.16% <ø> (ø) Carriedforward from 35a6633
eventindexer 77.29% <62.00%> (-4.80%) ⬇️
protocol 0.00% <ø> (ø) Carriedforward from 35a6633
relayer 60.71% <ø> (ø)
ui 100.00% <ø> (ø) Carriedforward from 35a6633

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ckages/protocol/contracts/L1/libs/LibProposing.sol 0.00% <ø> (ø)
packages/protocol/contracts/L1/libs/LibProving.sol 0.00% <ø> (ø)
packages/protocol/contracts/L1/libs/LibUtils.sol 0.00% <ø> (ø)
...ckages/protocol/contracts/L1/libs/LibVerifying.sol 0.00% <ø> (ø)
...ages/protocol/contracts/common/AddressResolver.sol 0.00% <ø> (ø)
...es/protocol/contracts/common/EssentialContract.sol 0.00% <ø> (ø)
...ackages/protocol/contracts/test/L1/TestTaikoL1.sol 0.00% <ø> (ø)
.../contracts/test/L1/TestTaikoL1EnableTokenomics.sol 0.00% <ø> (ø)
packages/eventindexer/repo/stat.go 56.75% <56.75%> (ø)
packages/eventindexer/http/get_stats.go 62.50% <62.50%> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

davidtaikocha
davidtaikocha previously approved these changes May 25, 2023
@davidtaikocha davidtaikocha added this pull request to the merge queue May 25, 2023
Merged via the queue into main with commit bfbbb97 May 25, 2023
@davidtaikocha davidtaikocha deleted the event_fix branch May 25, 2023 01:55
@github-actions github-actions bot mentioned this pull request May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants