Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): do not allow using owner() as named address in AddressManager #13771

Merged
merged 4 commits into from
May 17, 2023

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented May 17, 2023

If the oracle_prover and/or system_prover is the owner(), the private key will hot on our server which is more risky.

@dantaik dantaik changed the title Address manager minor feat(protocol): do not allow using owner() as named address in AddressManager May 17, 2023
@dantaik dantaik requested review from Brechtpd and dionysuzx May 17, 2023 02:07
@dantaik dantaik self-assigned this May 17, 2023
@dantaik dantaik marked this pull request as ready for review May 17, 2023 02:08
@dantaik dantaik requested a review from davidtaikocha May 17, 2023 02:11
@dantaik dantaik enabled auto-merge May 17, 2023 02:12
@dantaik dantaik added this pull request to the merge queue May 17, 2023
Merged via the queue into main with commit 12c810f May 17, 2023
@dantaik dantaik deleted the address_manager_minor branch May 17, 2023 06:48
@github-actions github-actions bot mentioned this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants